doc(recipes/identifier): convert to greedy parser #1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, the current recipe for
identifier
is greedy and likes to take everything that it can and silently stop if it sees something it doesn't like (i.e. whitespace). However, I think it would be a lot better to just make it check the entire string to be a valid identifier and just make use of themultispace1
or any other delimiters you want ((
,)
, ect.) surrounding theidentifier
when using it within a different parser (i.e. variable initialization as stated in the docs added). This should make it easier to use because I actually had a big bug that I didn't realize was there until later from theidentifier
saying it's valid when it's not because it requires you to check if the rest of the input(input, parsed)
is empty.Tests I used: